Add filetype argument to tar_terra_vect()
#21
Conversation
|
Not quite working yet. Somewhere I've not defined the object |
|
I perhaps wonder if once #19 is merged and this is rebased/merged off of that if it will help resolve some of those changes? |
Co-authored-by: Nicholas Tierney <[email protected]>
|
It passes checks! Did you want to merge now? |
|
If you'd rather merge #19 first, I can update this PR to use default options for filetype. Or we can merge them both and do that in a separate PR. Doesn't matter to me. |
|
I think I'd prefer to merge #19 first actually - there are a couple of changes that you requested, I'll comment on them in the PR - but maybe these could be addressed in separate issues. |
There was a problem hiding this comment.
Overall looks good to me, just spotted one tiny typo. Thanks for adding the links too!
We will need to create options for vector data to fix the {covr} failure, and should hash out the naming in #25
I spent a little bit looking into the mechanics of {covr} last night... for now I do not have an alternate solution to what was done in #19, so will want to use defaults via the geotargets_option_get() approach for vector data too
Co-authored-by: Andrew Gene Brown <[email protected]>
Merge commit 'b16bea407a74aad2cba1f708d37bd749a5807454' #Conflicts: # R/tar-terra-vect.R
I tried to replicate additions to
tar_terra_rast()intar_terra_vect(). I think ESRI Shapfiles need special handling, and potentially other formats won't work. I made the default format GeoJSON simply because it is an included driver and produces a single file.